Repository navigation
Declare non-exempt encryption in the iOS and Mac Info.plist - #1746
Merged
Merged
Conversation
Valour's end-to-end encryption uses its own implementations of standard algorithms (BouncyCastle) in addition to the operating system's, so ITSAppUsesNonExemptEncryption is true. App Store Connect stops asking the export compliance question for each uploaded build once the key is set.
The Mac app ships as a DMG today, where the key has no effect, but it is set now so a future Mac App Store build declares the same encryption as the iOS app.
SpikeViper
changed the title
Deploying valour-marketing with
|
| Latest commit: |
269e229
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05c1871c.valour-marketing.pages.dev |
| Branch Preview URL: | https://fix-ios-encryption-declarati.valour-marketing.pages.dev |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ITSAppUsesNonExemptEncryption = trueto the iOS and Mac CatalystInfo.plistfiles.Valour's end-to-end encryption uses its own implementations of standard algorithms (BouncyCastle in
Valour.Sdk) in addition to the operating system's encryption, which is the second case App Store Connect lists as needing documentation. The encryption documentation is already uploaded and in review. With the key set, App Store Connect stops asking the export compliance question for each uploaded build.The Mac app ships as a notarized DMG today, where the key has no effect. It is set now so a future Mac App Store build declares the same thing.
Once Apple approves the documentation, it shows a key value next to it. That value goes in both files as
ITSEncryptionExportComplianceCodein a follow-up change.